noCopy implements sync.Locker #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noCopy is used by -copylocks checker from `go vet`. see golang/go#8005 (comment) for details. but it doesn't work from Go 1.11, because of golang/go@c2eba53 and golang/go#26165 -copylock now works with structs that implement sync.Locker. So, noCopy should implement sync.Locker.
methane
approved these changes
May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
noCopy is used by
-copylockschecker fromgo vet.see golang/go#8005 (comment) for details.
but it doesn't work from Go 1.11, because of golang/go@c2eba53 and golang/go#26165
-copylocknow works with structs that implement sync.Locker.So, noCopy should implement sync.Locker.
related tweets (written in Japanese):
Checklist