GitHub: fix actions #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This mirrors the more recent GitHub setup from the logr repo which was more actively maintained and updated than the copy in zapr. The setup here suffered from bitrot and no longer worked.
It's no longer supported by the Go team and lacks atomic.Bool, which is required by one of the zapr dependencies.
pohly
force-pushed
the
fix-github-actions
branch
from
76553e7 to
c1d9757
Compare
slogtest.Run was added long ago enough that we can rely on it by dropping support for older Go releases.
The API was moved to the lop-level logr repo.
pohly
force-pushed
the
fix-github-actions
branch
from
c1d9757 to
a7113e4
Compare
|
@nilebox: does this look reasonable? |
|
/cc @thockin The |
|
/approve |
This was referenced Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This mirrors the more recent GitHub setup from the logr repo which was more actively maintained and updated than the copy in zapr. The setup here suffered from bitrot and no longer worked.