Skip to content

remove promise-polyfill #9812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 16, 2020
Merged

remove promise-polyfill #9812

merged 1 commit into from
Jan 16, 2020

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Jan 16, 2020 •
edited
Loading

Promises are polyfilled by babel, it's no longer needed.

Verified using string 'Promise-chain cycle' which is present in build files, comes from here.

@silverwind
Copy link
Member Author

I had missed the entry in public/vendor/librejs.html. Adjusted the .ignore pattern to no longer cover this file and removed the entry.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 16, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 16, 2020
@sapk sapk added type/miscellaneous skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Jan 16, 2020
@sapk sapk added this to the 1.12.0 milestone Jan 16, 2020
@silverwind
remove promise-polyfill
20497b0 
promises are polyfilled by babel, it's no longer needed.
@silverwind silverwind force-pushed the remove-promise-polyfill branch from d1b4dc9 to 20497b0 Compare January 16, 2020 22:14
@codecov-io
Copy link

codecov-io commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #9812 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9812      +/-   ##
==========================================
- Coverage   42.21%   42.21%   -0.01%     
==========================================
  Files         603      603              
  Lines       78879    78879              
==========================================
- Hits        33300    33296       -4     
- Misses      41497    41500       +3     
- Partials     4082     4083       +1
Impacted Files Coverage Δ
services/pull/check.go 50.34% <0%> (-4.2%) ⬇️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18e0447...20497b0. Read the comment docs.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2020
@zeripath zeripath merged commit cc2916d into go-gitea:master Jan 16, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/miscellaneous
Projects
None yet
Milestone
1.12.0
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @codecov-io @zeripath @sapk @GiteaBot