Skip to content

Conversation

zeripath
Copy link
Contributor

Move the mailer to use the generalised queue format.

This is a breakout from #8874

@zeripath zeripath added the type/enhancement An improvement of existing functionality label Jan 15, 2020
@zeripath zeripath added this to the 1.12.0 milestone Jan 15, 2020
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a nit.

BTW, I was thinking of configuring my mail to use file persistance and suddenly realized that we will have a versioning problem if we recklessly change some struct in the future. I thought I should mention it.

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 16, 2020
@zeripath
Copy link
Contributor Author

Oh damn I forgot we need to actually change the message to use something that is serialisable.

@zeripath
Copy link
Contributor Author

I need to add
7cb70d9

I.e.

git cherry-pick 7cb70d93c89da920467232457647009a831c6d05

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 16, 2020
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked again, because of the recent changes. It passes test and test-sqlite on my dev env and seems to work alright.

@codecov-io
Copy link

Codecov Report

Merging #9789 into master will increase coverage by 0.03%.
The diff coverage is 76.47%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9789      +/-   ##
==========================================
+ Coverage   42.18%   42.21%   +0.03%     
==========================================
  Files         603      603              
  Lines       78884    78885       +1     
==========================================
+ Hits        33275    33301      +26     
+ Misses      41531    41506      -25     
  Partials     4078     4078
Impacted Files Coverage Δ
modules/notification/webhook/webhook.go 37.97% <100%> (ø) ⬆️
services/pull/check.go 54.54% <100%> (+5.89%) ⬆️
modules/notification/action/action.go 35.65% <100%> (ø) ⬆️
modules/notification/base/null.go 62.5% <100%> (ø) ⬆️
modules/notification/notification.go 73.33% <100%> (ø) ⬆️
modules/notification/mail/mail.go 24.63% <100%> (ø) ⬆️
modules/notification/ui/ui.go 74.46% <100%> (ø) ⬆️
services/pull/merge.go 50.34% <100%> (ø) ⬆️
modules/migrations/github.go 78.73% <50%> (+1.12%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d5cb3...866ee91. Read the comment docs.

@sapk sapk merged commit c76c70a into go-gitea:master Jan 16, 2020
@zeripath zeripath deleted the queue-mailer branch January 16, 2020 19:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants