Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Nov 2, 2019

Issue milestone assignment is wrongly put on milestone service. This PR moved it to issue service and also move webhook to notification.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Nov 2, 2019
Copy link
Member

@guillep2k guillep2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lunny thank you for all the hard refactoring work. You rock! 💯

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Nov 2, 2019
@lunny lunny force-pushed the lunny/milestone_assign branch from 043b153 to b9d04e1 Compare November 2, 2019 02:39
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #8780 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8780      +/-   ##
==========================================
+ Coverage   41.36%   41.36%   +<.01%     
==========================================
  Files         541      541              
  Lines       69477    69482       +5     
==========================================
+ Hits        28739    28743       +4     
- Misses      37058    37059       +1     
  Partials     3680     3680
Impacted Files Coverage Δ
routers/api/v1/repo/pull.go 36.17% <0%> (ø) ⬆️
modules/notification/webhook/webhook.go 40.2% <0%> (-4.37%) ⬇️
routers/api/v1/repo/issue.go 18.66% <0%> (ø) ⬆️
modules/notification/notification.go 74.46% <0%> (ø) ⬆️
modules/notification/base/null.go 63.63% <0%> (ø) ⬆️
routers/repo/issue.go 34.36% <0%> (ø) ⬆️
services/issue/milestone.go 0% <0%> (ø)
modules/process/manager.go 78.37% <0%> (-4.06%) ⬇️
models/gpg_key.go 55.59% <0%> (+0.55%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f518fe6...b9d04e1. Read the comment docs.

@lunny lunny merged commit 8f26397 into go-gitea:master Nov 2, 2019
@lunny lunny deleted the lunny/milestone_assign branch November 2, 2019 03:33
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants