Refactor Issues Subscription #8738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
force-pushed
the
refactor_issues-subscription
branch
from
f7a788d to
aa31558
Compare
6543
commented
Nov 6, 2019
GiteaBot
added
the
lgtm/need 2
|
move ToDos into new issue: #8852 to make refactor independend from feature additions |
because I'll implement this in a different way and in another PR
6543
commented
Nov 15, 2019
6543
force-pushed
the
refactor_issues-subscription
branch
from
37d0624 to
0ac149a
Compare
|
It's no longer leaking the mail addresses through this endpoint. However, there's no longer a way for admins to get the users' addresses through most endpoints including this ( |
|
@guillep2k the PR dont change API behaviour only fix a bug and refactor code ... |
|
@lunny this PR is ready ... |
zeripath
approved these changes
Nov 17, 2019
GiteaBot
added
lgtm/need 1
|
Make L-G-T-M work |
lunny
requested changes
Nov 17, 2019
|
@guillep2k I removed this "fix" - because there was no bug user.apiformat already handle this for us ... |
|
@lunny can you look at #8738 (comment) plz |
lunny
added
the
type/refactoring
lunny
approved these changes
Nov 20, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX: getIssueWatchers() get only aktive suscriber
update tests
add tests
ignore issue if unsubscribed but repowatch(Moved to Issues Subscription different Types #8852)