Skip to content

Hide some user information via API if user have no enough permission (#8655) #8658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2019
Merged

Hide some user information via API if user have no enough permission (#8655) #8658

merged 1 commit into from
Oct 24, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Oct 24, 2019

  • Hide some user information via API if user have no enough permission
  • fix test

backport from #8655

@lunny
Hide some user information via API if user have no enough permission (g…
978c567 
…o-gitea#8655)

* Hide some user information via API if user have no enough permission

* fix test
@lunny lunny added the type/bug label Oct 24, 2019
@lunny lunny added this to the 1.9.5 milestone Oct 24, 2019
@lunny lunny added the pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! label Oct 24, 2019
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 24, 2019
@lafriks lafriks added modifies/api This PR adds API routes or modifies them topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! and removed type/bug labels Oct 24, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 24, 2019
@lafriks lafriks merged commit 63c54f7 into go-gitea:release/v1.9 Oct 24, 2019
@lunny lunny deleted the lunny/fix_api_user_info3 branch October 24, 2019 08:22
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

+1 more reviewer

@guillep2k guillep2k guillep2k approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them pr/breaking Merging this PR means builds will break. Needs a description what exactly breaks, and how to fix it! topic/security Something leaks user information or is otherwise vulnerable. Should be fixed!
Projects
None yet
Milestone
1.9.5
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @lafriks @guillep2k @GiteaBot