Skip to content

Unit tests for models/issue_label #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2017
Merged

Unit tests for models/issue_label #802

merged 1 commit into from
Feb 1, 2017

Conversation

ethantkoenig
Copy link
Member

@ethantkoenig ethantkoenig commented Jan 31, 2017 •
edited
Loading

Fixes a bug in deleteIssueLabel(..) that incorrectly decremented label.NumIssues and label.NumClosedIssues.

Also makes a couple small tweaks to models/issue_label.go:

  1. Have getLabelInRepoByName(..) and getLabelInRepoByName(..) use their e arguments (previously were not used).
  2. Remove the unused GetIssueLabels(..) function.
  3. Reorder the arguments to deleteIssueLabel(..) and DeleteIssueLabel(..) to match newIssueLabel(..), NewIssueLabel(..), NewIssueLabels(..) and newIssueLabels(..).

@lunny lunny added this to the 1.1.0 milestone Jan 31, 2017
@lunny lunny added type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing labels Jan 31, 2017
@lunny
Copy link
Member

lunny commented Jan 31, 2017

LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jan 31, 2017
@appleboy
Copy link
Member

LGTM

@appleboy
Copy link
Member

make L-G-T-M work

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 31, 2017
@ethantkoenig
Copy link
Member Author

ethantkoenig commented Jan 31, 2017 •
edited
Loading

Wait, don't merge yet

@ethantkoenig
Copy link
Member Author

Okay, now you can merge.

@lunny
Copy link
Member

lunny commented Jan 31, 2017

build failed.

@ethantkoenig
Copy link
Member Author

Fixed

@lunny lunny merged commit 10644d6 into go-gitea:master Feb 1, 2017
@ethantkoenig ethantkoenig deleted the tests/issue_label branch February 4, 2017 04:28
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@appleboy appleboy appleboy approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality. type/testing
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ethantkoenig @lunny @appleboy @tboerger