Skip to content

Conversation

sapk
Copy link
Member

@sapk sapk commented Aug 1, 2019

To catch failure that can happen like with #7688

Related: #7701

@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 1, 2019
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Aug 1, 2019
@lafriks lafriks added this to the 1.10.0 milestone Aug 1, 2019
@sapk
Copy link
Member Author

sapk commented Aug 1, 2019

Perfect, the first run on the unfixed master has proved that it will catch similar error.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 1, 2019
@codecov-io
Copy link

Codecov Report

Merging #7707 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7707      +/-   ##
==========================================
- Coverage   41.24%   41.23%   -0.01%     
==========================================
  Files         471      471              
  Lines       63759    63759              
==========================================
- Hits        26296    26292       -4     
- Misses      34030    34034       +4     
  Partials     3433     3433
Impacted Files Coverage Δ
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e503794...ef8c0ba. Read the comment docs.

@techknowlogick techknowlogick merged commit c1b09c3 into go-gitea:master Aug 1, 2019
@sapk sapk deleted the drone-test-linux-386 branch August 1, 2019 18:27
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants