Skip to content

Alpine 3.10 #7256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 20, 2019
Merged

Alpine 3.10 #7256

merged 5 commits into from
Jun 20, 2019

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Jun 19, 2019 •
edited
Loading

As title.

Note: in dockerfile build step needs to have image updated too, but that's pending golang:1.12-alpine3.10

@codecov-io
Copy link

codecov-io commented Jun 19, 2019 •
edited
Loading

Codecov Report

Merging #7256 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7256      +/-   ##
==========================================
- Coverage   40.99%   40.98%   -0.01%     
==========================================
  Files         462      462              
  Lines       62578    62578              
==========================================
- Hits        25654    25650       -4     
- Misses      33561    33566       +5     
+ Partials     3363     3362       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️
routers/repo/view.go 42.23% <0%> (-1.02%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update de9b398...57c95d5. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 19, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2019
@sapk
Copy link
Member

sapk commented Jun 19, 2019

PR for golang:1.12-alpine3.10 is waiting validation. 😄

@sapk
Copy link
Member

sapk commented Jun 20, 2019

PR docker-library/golang#285 merged.
Build should come soon.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2019
@lafriks lafriks added the topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile label Jun 20, 2019
@lafriks lafriks added this to the 1.9.0 milestone Jun 20, 2019
@techknowlogick techknowlogick merged commit 8db4541 into go-gitea:master Jun 20, 2019
@techknowlogick techknowlogick deleted the alpine-3.10 branch June 21, 2019 00:25
aswild pushed a commit to aswild/gitea that referenced this pull request Jul 1, 2019
@techknowlogick @aswild
Alpine 3.10 (go-gitea#7256)
1a5ebbb
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@techknowlogick @jeffliu27
Alpine 3.10 (go-gitea#7256)
334ff2e
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@techknowlogick @codecov-io @sapk @zeripath @lafriks @GiteaBot @lunny