Don't post process commit summary in templates #6842
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't run summary through render/post process to avoid it generating links and breaking certain views where the summary is already expected to be a link to the commit. For consistancy, disable processing of summary in all locations. Fixes go-gitea#6809
Codecov Report
@@ Coverage Diff @@
## master #6842 +/- ##
=========================================
Coverage ? 41.14%
=========================================
Files ? 425
Lines ? 58484
Branches ? 0
=========================================
Hits ? 24061
Misses ? 31238
Partials ? 3185Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
On second thought, the title is often the only place a pull request number will exists so do process it on the individual diff page. This fixes the list view and still gives easy access to the PR link
|
Also up for feedback if keeping certain auto generated links in the summary title is something that is a very desired feature. |
zeripath
approved these changes
May 5, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
May 5, 2019
GiteaBot
added
lgtm/done
|
As @lunny says in the underlying issue, this should probably be backported. |
lafriks
pushed a commit
that referenced
this pull request
May 6, 2019
Backport #6842 credit to @mrsdizzie
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't run summary through render/post process on certain list views where it is already expected to be a link to the individual commit. This avoids inconsistent UI in some cases.
Fixes #6809