Skip to content

Fix regression in #248 #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 5, 2016
Merged

Fix regression in #248 #349

merged 3 commits into from
Dec 5, 2016

Conversation

bkcsoft
Copy link
Member

@bkcsoft bkcsoft commented Dec 5, 2016 •
edited
Loading

This fixes a regression in #248 where Closing a PR in the WebUI make gitea throw a panic.

Closes #344

It fixes the problem, PRs can now be closed in WebUI, but it still spits out error-logs in the console... Doesn't do this anymore since I'm actually populating the Head/BaseRepo now 😈

Started POST /toor/foobar/issues/1/comments for [::1]
[D] Session ID: 6aa78f141f0be42a
[D] CSRF Token: EVvkiIBTdh2Js1LIMFOoBLjP84s6MTQ4MDkyNzI1MTYxMjU2ODk0Mw==
[T] Issue [1] status changed to closed: true
[T] DeliverHooks [repo_id: 1]
Completed /toor/foobar/issues/1/comments 302 Found in 36.378904ms

Started GET /toor/foobar/pulls/1 for [::1]
[D] Session ID: 6aa78f141f0be42a
[D] CSRF Token: EVvkiIBTdh2Js1LIMFOoBLjP84s6MTQ4MDkyNzI1MTYxMjU2ODk0Mw==
[D] Template: repo/issue/view
Completed /toor/foobar/pulls/1 200 OK in 57.302163ms

@bkcsoft bkcsoft added type/bug issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP labels Dec 5, 2016
@bkcsoft bkcsoft added this to the 1.0.0 milestone Dec 5, 2016
@bkcsoft bkcsoft mentioned this pull request Dec 5, 2016
Closed
@Bwko
Copy link
Member

Bwko commented Dec 5, 2016

Fixes #344 so LGTM

@tboerger tboerger added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Dec 5, 2016
@bkcsoft
Copy link
Member Author

bkcsoft commented Dec 5, 2016

@Bwko Now I've actually fixed it, please update and try it again to see if the error goes away 🙂

@tboerger
Copy link
Member

tboerger commented Dec 5, 2016

LGTM

@tboerger tboerger added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 5, 2016
@bkcsoft
Copy link
Member Author

bkcsoft commented Dec 5, 2016

Cleaned up the log-msgs :)

@Bwko
Copy link
Member

Bwko commented Dec 5, 2016

Yes your new fix actually fixes the problem, the error is gone :)

@bkcsoft
Copy link
Member Author

bkcsoft commented Dec 5, 2016

Errors gone, Issue fixed, All things Green, Merging 😄

@bkcsoft bkcsoft merged commit d07c955 into master Dec 5, 2016
@bkcsoft bkcsoft deleted the bkcsoft/344-fix-close-pr-regression branch December 5, 2016 11:17
@go-gitea go-gitea locked and limited conversation to collaborators Nov 23, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
issue/critical This issue should be fixed ASAP. If it is a PR, the PR should be merged ASAP lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Closing a pull request makes Gitea crash
3 participants
@bkcsoft @Bwko @tboerger