[Fix] Trigger 'unlabeled' event when label is Deleted from PR #34316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts for label addition/removal scenarios
GiteaBot
added
the
lgtm/need 2
Sumit189
changed the title
lunny
reviewed
Apr 29, 2025
…nd add corresponding tests
…gitea into label_delete_event_fix
lunny
reviewed
Apr 29, 2025
Co-authored-by: Lunny Xiao <[email protected]>
|
The change in method |
I made changes in the relevant methods, but I'm not sure how to test those changes. @lunny, can you help validate this? |
You could create an integration test for this, there are mock runners and you can find some examples. |
lunny
reviewed
May 11, 2025
lunny
added
type/enhancement
…to Sumit189-label_delete_event_fix
github-actions
bot
added
modifies/translation
topic/code-linting
modifies/api
github-actions
bot
removed
modifies/translation
topic/code-linting
modifies/api
lunny
approved these changes
Sep 8, 2025
GiteaBot
added
lgtm/need 1
Sumit189
commented
Sep 8, 2025
|
last call @go-gitea/technical-oversight-committee |
darren
pushed a commit
to darren/gitea
that referenced
this pull request
Sep 25, 2025
…ea#34316) This pull request updates the handling of issue label events in workflows to distinguish between label additions and deletions, introduces corresponding test cases, and extends the `IssuePayload` structure to support this functionality. ### Enhancements to issue label event handling: * Updated `matchIssuesEvent` in `modules/actions/workflows.go` to differentiate between "labeled" and "unlabeled" events based on whether labels were added or removed. * Added a new field, `RemovedLabels`, to the `IssuePayload` struct in `modules/structs/hook.go` to track labels that were removed during an issue event. ### Testing improvements: * Added `TestMatchIssuesEvent` in `modules/actions/workflows_test.go` to cover scenarios such as label addition, label deletion, and label clearing, ensuring the correct event type is triggered. --------- Co-authored-by: Lunny Xiao <[email protected]>
rossigee
pushed a commit
to rossigee/gitea
that referenced
this pull request
Sep 26, 2025
…ea#34316) This pull request updates the handling of issue label events in workflows to distinguish between label additions and deletions, introduces corresponding test cases, and extends the `IssuePayload` structure to support this functionality. ### Enhancements to issue label event handling: * Updated `matchIssuesEvent` in `modules/actions/workflows.go` to differentiate between "labeled" and "unlabeled" events based on whether labels were added or removed. * Added a new field, `RemovedLabels`, to the `IssuePayload` struct in `modules/structs/hook.go` to track labels that were removed during an issue event. ### Testing improvements: * Added `TestMatchIssuesEvent` in `modules/actions/workflows_test.go` to cover scenarios such as label addition, label deletion, and label clearing, ensuring the correct event type is triggered. --------- Co-authored-by: Lunny Xiao <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 29, 2025
* commit '53dfbbb2eee5f9ae7b1a127b51fd9ab5accf5e89': Update issue.go with labels documentation (labels content, not ids) (go-gitea#35522) Fix markup init after issue comment editing (go-gitea#35536) [Fix] Trigger 'unlabeled' event when label is Deleted from PR (go-gitea#34316) [skip ci] Updated translations via Crowdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the handling of issue label events in workflows to distinguish between label additions and deletions, introduces corresponding test cases, and extends the
IssuePayloadstructure to support this functionality.Enhancements to issue label event handling:
matchIssuesEventinmodules/actions/workflows.goto differentiate between "labeled" and "unlabeled" events based on whether labels were added or removed.RemovedLabels, to theIssuePayloadstruct inmodules/structs/hook.goto track labels that were removed during an issue event.Testing improvements:
TestMatchIssuesEventinmodules/actions/workflows_test.goto cover scenarios such as label addition, label deletion, and label clearing, ensuring the correct event type is triggered.