Skip to content

Conversation

ChristopherHX
Copy link
Contributor

@ChristopherHX ChristopherHX commented Mar 21, 2025

Implements

Fixes

  • workflow_job webhook url to no longer contain the runs/<run> part to align with api
  • workflow instance does now use it's name inside the file instead of filename if set

Refactoring

  • Moved a lot of logic from workflows/workflow_job into a shared module used by both webhook and api

TODO

  • Verify Keda Compatibility
  • Edit Webhook API bug is resolved

Closes #23670
Closes #23796
Closes #24898
Replaces #28047 and is much more complete

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 21, 2025
@github-actions github-actions bot added modifies/translation modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Mar 21, 2025
@wxiaoguang
Copy link
Contributor

Ready for review?

@ChristopherHX
Copy link
Contributor Author

My time to respond or make changes is limited in the next seven days, due to exams.

Other than that, yes I think this is ready for review.

Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No hurry, overall looks good. Thank you very much.

(Maybe will take a look again later)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 19, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2025
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did another round review. I think it looks good to me.

Is there anything else to change? If no, let's merge ~~ 🙏

@ChristopherHX
Copy link
Contributor Author

Is there anything else to change?

Nothing that I am aware of, I agree with merging this now. Then I can polish the keda scaler side of things soon and move that one out of a draft.

@wxiaoguang wxiaoguang merged commit cda90ec into go-gitea:main Jun 20, 2025
26 checks passed
bdruth added a commit to bdruth/gitea that referenced this pull request Jun 28, 2025
Implements additional query parameters for the workflow runs API to match GitHub's REST API specification.

- Add `exclude_pull_requests` query parameter
- Add `check_suite_id` parameter
- Add `created` parameter with date range and comparison support
- Add workflow-specific endpoint `/repos/{owner}/{repo}/actions/workflows/{workflow_id}/runs`

Builds on the workflow API foundation from go-gitea#33964 to provide additional GitHub API compatibility.

Reference: https://docs.github.com/en/rest/actions/workflow-runs?apiVersion=2022-11-28#list-workflow-runs-for-a-workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code modifies/templates This PR modifies the template files modifies/translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

workflow_run for action trigger event Webhook trigger for actions (CI) Implement workflow_* webhook event
5 participants