Skip to content

Conversation

kerwin612
Copy link
Member

@kerwin612 kerwin612 commented Jun 6, 2024

before:
1717655078227
The problem was that the icon and text were not on a horizontal line, and the horizontal was not centered;

after:
1717655094071

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 6, 2024
@github-actions github-actions bot added the modifies/templates This PR modifies the template files label Jun 6, 2024
@kerwin612 kerwin612 requested a review from wxiaoguang June 6, 2024 08:17
@wxiaoguang
Copy link
Contributor

wxiaoguang commented Jun 6, 2024

One more thing, I think we should remove all "iconFloat". It can't be right with "flex".

Details:

image

kerwin612 and others added 3 commits June 6, 2024 16:22
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 6, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 6, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 6, 2024
@silverwind silverwind merged commit 8e33746 into go-gitea:main Jun 6, 2024
@GiteaBot GiteaBot added this to the 1.23.0 milestone Jun 6, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Jun 6, 2024
@silverwind silverwind added the backport/v1.22 This PR should be backported to Gitea 1.22 label Jun 6, 2024
GiteaBot added a commit to GiteaBot/gitea that referenced this pull request Jun 6, 2024
before: 

![1717655078227](https://github.com/go-gitea/gitea/assets/3371163/4d564f96-c2f8-46b1-996f-6cc7abb940ef)
***The problem was that the icon and text were not on a horizontal line,
and the horizontal was not centered;***

after: 

![1717655094071](https://github.com/go-gitea/gitea/assets/3371163/b11797f6-05f8-486c-b5fd-df89d0cbdcfd)

---------

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: Giteabot <[email protected]>
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Jun 6, 2024
silverwind pushed a commit that referenced this pull request Jun 7, 2024
Backport #31272 by @kerwin612

before: 

![1717655078227](https://github.com/go-gitea/gitea/assets/3371163/4d564f96-c2f8-46b1-996f-6cc7abb940ef)
***The problem was that the icon and text were not on a horizontal line,
and the horizontal was not centered;***

after: 

![1717655094071](https://github.com/go-gitea/gitea/assets/3371163/b11797f6-05f8-486c-b5fd-df89d0cbdcfd)

Co-authored-by: Kerwin Bryant <[email protected]>
Co-authored-by: wxiaoguang <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 7, 2024
* giteaofficial/main:
  Fix and clean up `ConfirmModal` (go-gitea#31283)
  Enable poetry non-package mode (go-gitea#31282)
  fixed the dropdown menu for the top New button to expand to the left (go-gitea#31273)
  Optimize repo-list layout to enhance visual experience (go-gitea#31272)
  Allow including `Reviewed-on`/`Reviewed-by` lines for custom merge messages (go-gitea#31211)
  Add `MAX_ROWS` option for CSV rendering (go-gitea#30268)
  Update `golang.org/x/net` (go-gitea#31260)
  Add replacement module for `mholt/archiver` (go-gitea#31267)
  Fix Activity Page Contributors dropdown (go-gitea#31264)
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Sep 5, 2024
@wxiaoguang wxiaoguang deleted the patch-10 branch March 5, 2025 11:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/templates This PR modifies the template files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants