Skip to content

fix(api): refactor branch and tag existence checks #30618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 21, 2024
Merged

fix(api): refactor branch and tag existence checks #30618

merged 8 commits into from
Apr 21, 2024

Conversation

appleboy
Copy link
Member

  • Update branch existence check to also include tag existence check
  • Adjust error message for branch/tag existence check

ref: #30349

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 20, 2024
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Apr 20, 2024
@appleboy
fix: refactor branch and tag existence checks
e9e900e 
- Update branch existence check to also include tag existence check
- Adjust error message for branch/tag existence check

Signed-off-by: appleboy <[email protected]>
@appleboy appleboy added this to the 1.23.0 milestone Apr 20, 2024
@appleboy appleboy requested review from lunny and wolfogre April 20, 2024 13:14
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2024
wxiaoguang
wxiaoguang reviewed Apr 20, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Apr 21, 2024
View reviewed changes
wxiaoguang
wxiaoguang approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, the name ambiguity is a longstanding problem. I guess it couldn't be simply fixed soon.

Although it isn't right, it just works.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 21, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 21, 2024
@silverwind silverwind merged commit 6459c50 into go-gitea:main Apr 21, 2024
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 21, 2024
@appleboy appleboy deleted the compare branch April 22, 2024 02:58
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 22, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
f607c27 
* giteaofficial/main:
  [skip ci] Updated licenses and gitignores
  Use correct hash for "git update-index" (go-gitea#30626)
  Fix repo home UI when there is no repo description (go-gitea#30552)
  Fix dropdown text ellipsis (go-gitea#30628)
  fix(api): refactor branch and tag existence checks (go-gitea#30618)
  Add --skip-db option to dump command (go-gitea#30613)
  Fix flash on dashboard (go-gitea#30572)
  chore: use errors.New to replace fmt.Errorf with no parameters will much better (go-gitea#30621)
  Fix issue comment form and quick-submit (go-gitea#30623)
  Use maintained gziphandler (go-gitea#30592)
  [skip ci] Updated translations via Crowdin
  Fix package list performance (go-gitea#30520)
  Clarify permission "HasAccess" behavior (go-gitea#30585)
  Fix links in PyPI Simple Repository API page (go-gitea#30594)
  Use action user as the trigger user of schedules (go-gitea#30581)
  Fix commit file status parser (go-gitea#30602)
  Fix HEAD method for robots.txt (go-gitea#30603)
@ExplodingDragon ExplodingDragon mentioned this pull request Apr 23, 2024
Closed
silverwind added a commit to silverwind/gitea that referenced this pull request Apr 23, 2024
@silverwind
Merge remote-tracking branch 'origin/main' into notext
453c63d 
* origin/main:
  Interpolate runs-on with variables when scheduling tasks (go-gitea#30640)
  Initial support for colorblindness-friendly themes (go-gitea#30625)
  Fix flash message for flex-container (go-gitea#30657)
  Perform Newest sort type correctly when sorting issues (go-gitea#30644)
  Fix project name wrapping, remove horizontal margin on header (go-gitea#30631)
  Add a db consistency check to remove runners that do not belong to a repository (go-gitea#30614)
  Fix wrong table name (go-gitea#30557)
  Fix compare api swagger (go-gitea#30648)
  [skip ci] Updated translations via Crowdin
  Fix queue test (go-gitea#30646)
  Enable jquery-related eslint rules that have no violations (go-gitea#30632)
  Enable more `revive` linter rules (go-gitea#30608)
  Remove obsolete CSS text classes (go-gitea#30576)
  Hide diff stats on empty PRs (go-gitea#30629)
  [skip ci] Updated licenses and gitignores
  Use correct hash for "git update-index" (go-gitea#30626)
  Fix repo home UI when there is no repo description (go-gitea#30552)
  Fix dropdown text ellipsis (go-gitea#30628)
  fix(api): refactor branch and tag existence checks (go-gitea#30618)
  Add --skip-db option to dump command (go-gitea#30613)
@wxiaoguang wxiaoguang modified the milestones: 1.23.0, 1.22.0 Apr 27, 2024
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Jul 21, 2024
@wxiaoguang
Copy link
Contributor

@appleboy regression?

-> comparison api unable to calculate the difference between the commit IDs #30655

-> The interface to get submission comparison information is not as expected #32723

@wxiaoguang
Copy link
Contributor

-> Make API "compare" accept commit IDs #32801

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@wolfogre wolfogre Awaiting requested review from wolfogre

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code
Projects
None yet
Milestone
1.22.0
Development

Successfully merging this pull request may close these issues.
5 participants
@appleboy @wxiaoguang @lunny @silverwind @GiteaBot