Skip to content

Remove jQuery .attr from the project page #30004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Remove jQuery .attr from the project page #30004

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
887c3c2
Remove jQuery `.attr` from the project page
yardenshoham Mar 22, 2024
263f1e4
Update web_src/js/features/repo-projects.js
yardenshoham Mar 22, 2024
d15e191
Merge branch 'main' into repo-projects-jquery-attr
GiteaBot Mar 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions web_src/js/features/repo-projects.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ async function moveIssue({item, from, to, oldIndex}) {

const columnSorting = {
issues: Array.from(columnCards, (card, i) => ({
issueID: parseInt($(card).attr('data-issue')),
issueID: parseInt(card.getAttribute('data-issue')),
sorting: i,
})),
};
Expand Down Expand Up @@ -134,7 +134,7 @@ export function initRepoProject() {
if ($projectColorInput.val()) {
setLabelColor($projectHeader, $projectColorInput.val());
}
$boardColumn.attr('style', `background: ${$projectColorInput.val()}!important`);
$boardColumn[0].style = `background: ${$projectColorInput.val()} !important`;
$('.ui.modal').modal('hide');
}
});
Expand All @@ -159,9 +159,9 @@ export function initRepoProject() {
});

$('.show-delete-project-column-modal').each(function () {
const $deleteColumnModal = $(`${$(this).attr('data-modal')}`);
const $deleteColumnModal = $(`${this.getAttribute('data-modal')}`);
const $deleteColumnButton = $deleteColumnModal.find('.actions > .ok.button');
const deleteUrl = $(this).attr('data-url');
const deleteUrl = this.getAttribute('data-url');

$deleteColumnButton.on('click', async (e) => {
e.preventDefault();
Expand Down