Skip to content

Remove jQuery .attr from the user search box #29919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 20, 2024
Merged

Remove jQuery .attr from the user search box #29919

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1a6950a
Remove jQuery `.attr` from the user search box
yardenshoham Mar 19, 2024
709be5e
Merge branch 'main' into search-user-box-jquery-attr
GiteaBot Mar 20, 2024
8364bd0
Merge branch 'main' into search-user-box-jquery-attr
GiteaBot Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions web_src/js/features/comp/SearchUserBox.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,12 @@ const {appSubUrl} = window.config;
const looksLikeEmailAddressCheck = /^\S+@\S+$/;

export function initCompSearchUserBox() {
const $searchUserBox = $('#search-user-box');
const allowEmailInput = $searchUserBox.attr('data-allow-email') === 'true';
const allowEmailDescription = $searchUserBox.attr('data-allow-email-description');
const searchUserBox = document.getElementById('search-user-box');
if (!searchUserBox) return;

const $searchUserBox = $(searchUserBox);
const allowEmailInput = searchUserBox.getAttribute('data-allow-email') === 'true';
const allowEmailDescription = searchUserBox.getAttribute('data-allow-email-description') ?? undefined;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, we need to be aware that getAttribute returns null when not present, while jQuery returned undefined.

$searchUserBox.search({
minCharacters: 2,
apiSettings: {
Expand Down