Skip to content

Remove jQuery from the "quick submit" handler #29200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Remove jQuery from the "quick submit" handler #29200

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e082a21
Remove jQuery from the "quick submit" handler
yardenshoham Feb 16, 2024
a97d30a
Use `SubmitEvent`
yardenshoham Feb 16, 2024
cf8d365
Remove defaults
yardenshoham Feb 16, 2024
01ee4c2
Revert "Remove defaults"
yardenshoham Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions web_src/js/features/comp/QuickSubmit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
import $ from 'jquery';

export function handleGlobalEnterQuickSubmit(target) {
const form = target.closest('form');
if (form) {
Expand All @@ -8,14 +6,9 @@ export function handleGlobalEnterQuickSubmit(target) {
return;
}

if (form.classList.contains('form-fetch-action')) {
form.dispatchEvent(new SubmitEvent('submit', {bubbles: true, cancelable: true}));
return;
}

// here use the event to trigger the submit event (instead of calling `submit()` method directly)
// otherwise the `areYouSure` handler won't be executed, then there will be an annoying "confirm to leave" dialog
$(form).trigger('submit');
form.dispatchEvent(new SubmitEvent('submit', {bubbles: true, cancelable: true}));
} else {
// if no form, then the editor is for an AJAX request, dispatch an event to the target, let the target's event handler to do the AJAX request.
// the 'ce-' prefix means this is a CustomEvent
Expand Down