Skip to content

Warn that DISABLE_QUERY_AUTH_TOKEN is false only if it's explicitly defined (#28783) #28868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 21, 2024
Merged

Warn that DISABLE_QUERY_AUTH_TOKEN is false only if it's explicitly defined (#28783) #28868

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f4c1a1
Warn that `DISABLE_QUERY_AUTH_TOKEN` is false only if it's explicitly…
yardenshoham Jan 14, 2024
6d4c8dc
Merge branch 'release/v1.21' into backport-28783-v1.21
GiteaBot Jan 21, 2024
41797b3
Merge branch 'release/v1.21' into backport-28783-v1.21
GiteaBot Jan 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion modules/setting/security.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,10 +161,13 @@ func loadSecurityFrom(rootCfg ConfigProvider) {
}
}

sectionHasDisableQueryAuthToken := sec.HasKey("DISABLE_QUERY_AUTH_TOKEN")

// TODO: default value should be true in future releases
DisableQueryAuthToken = sec.Key("DISABLE_QUERY_AUTH_TOKEN").MustBool(false)

if !DisableQueryAuthToken {
// warn if the setting is set to false explicitly
if sectionHasDisableQueryAuthToken && !DisableQueryAuthToken {
log.Warn("Enabling Query API Auth tokens is not recommended. DISABLE_QUERY_AUTH_TOKEN will default to true in gitea 1.23 and will be removed in gitea 1.24.")
}
}