Skip to content

Move some JS code from fomantic.js to standalone files (#27994) #28001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2023
Merged

Move some JS code from fomantic.js to standalone files (#27994) #28001

merged 1 commit into from
Nov 12, 2023

Conversation

GiteaBot
Copy link
Collaborator

Backport #27994 by @wxiaoguang

To improve maintainability, this PR:

  1. Rename web_src/js/modules/aria to web_src/js/modules/fomantic (the code there are all for aria of fomantic)
  2. Move api/transition related code to web_src/js/modules/fomantic/api.js and web_src/js/modules/fomantic/transition.js

No logic is changed.

@wxiaoguang @GiteaBot
Move some JS code from fomantic.js to standalone files (go-gitea#27994
a8704ad 
)

To improve maintainability, this PR: 

1. Rename `web_src/js/modules/aria` to `web_src/js/modules/fomantic`
(the code there are all for aria of fomantic)
2. Move api/transition related code to
`web_src/js/modules/fomantic/api.js` and
`web_src/js/modules/fomantic/transition.js`

No logic is changed.
@GiteaBot GiteaBot added modifies/docs modifies/frontend skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality. labels Nov 12, 2023
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 12, 2023
@GiteaBot GiteaBot added this to the 1.21.0 milestone Nov 12, 2023
@GiteaBot GiteaBot requested review from delvh and lunny November 12, 2023 07:15
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 12, 2023
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 12, 2023
@silverwind silverwind merged commit 58d71cd into go-gitea:release/v1.21 Nov 12, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Feb 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

@lunny lunny Awaiting requested review from lunny

Assignees

@wxiaoguang wxiaoguang

Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/docs skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.21.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GiteaBot @silverwind @delvh @wxiaoguang