Fix activity inconsistency when delete pull request #26285
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
CaiCandong
changed the title
CaiCandong
changed the title
|
It's not right. I fix it by the way in Bypass MariaDB performance bug of the "IN" sub-query, fix incorrect IssueIndex #26279 Thank you for your finding and report 😆 |
You're right, I didn't notice the operation related to |
|
It's will be fixed in #26279 |
…tency-when-delete-pr
delvh
approved these changes
Aug 6, 2023
GiteaBot
added
lgtm/need 1
wxiaoguang
requested changes
Aug 6, 2023
There was a problem hiding this comment.
Please review #26279 which has a full fix for this problem and has tests.
GiteaBot
added
lgtm/blocked
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Aug 7, 2023
lunny
pushed a commit
that referenced
this pull request
Aug 7, 2023
…ssueIndex (#26279) (#26368) Backport #26279 by @wxiaoguang Close #26277 Fix #26285 Co-authored-by: wxiaoguang <[email protected]>
project-mirrors-bot-tu bot
pushed a commit
to project-mirrors/forgejo-as-gitea-fork
that referenced
this pull request
Jan 23, 2025
…ssueIndex (go-gitea#26279) (go-gitea#26368) Backport go-gitea#26279 by @wxiaoguang Close go-gitea#26277 Fix go-gitea#26285 Co-authored-by: wxiaoguang <[email protected]> (cherry picked from commit cb1a4da)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description：
When I delete a PR, I find that the entry is still in the feed stream on the home page. If I click on it, I get 404 and 500 errors.
Causes:
When deleting the Issue, the corresponding
activitywas deleted usingissue.IDby mistake, when it should have usedissue.Index.Screenshot(gif):
