Enable all webpack sourcemaps in dev build, disable all in prod build #25089
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
silverwind
added
topic/build
silverwind
changed the title
a1012112796
approved these changes
Jun 6, 2023
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Jun 6, 2023
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
GiteaBot
removed
the
reviewed/wait-merge
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jun 6, 2023
* upstream/main: (26 commits) Clean up WebAuthn javascript code and remove JQuery code (go-gitea#22697) Enable all webpack sourcemaps in dev build, disable all in prod build (go-gitea#25089) Don't display `select all issues` checkbox when no issues are available (go-gitea#25086) change placeholders in actions docs change placeholders in actions docs fix "Remove stars when repo goes private go-gitea#19904" (go-gitea#25084) Introduce how to configure cache when starting a Runner with Docker (go-gitea#25077) Remove stars when repo goes private (go-gitea#19904) Use correct selector for hiding RSS icon link in the branch selector dropdown (go-gitea#25080) Fix parallelly generating index failure with Mysql (go-gitea#24567) Use git command instead of the ini package to remove the `origin` remote (go-gitea#25066) improve permission documentation (go-gitea#23942) Use RepositoryList instead of []*Repository (go-gitea#25074) Add ability to set multiple redirect URIs in OAuth application UI (go-gitea#25072) Add Progressbar to Milestone Page (go-gitea#25050) [skip ci] Updated licenses and gitignores Redesign Scoped Access Tokens (go-gitea#24767) Use a separate admin page to show global stats, remove `actions` stat (go-gitea#25062) Remove cancel button from branch protection form (go-gitea#25063) Allow for PKCE flow without client secret + add docs (go-gitea#25033) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ENABLE_SOURCEMAPenv var to override it.I think the strange error seen in #24784 is sourcemap related, so if we enable/disable them all, it might go away. But it's most definitely a Safari bug.
With all sourcemaps disabled, binary size goes down by around 1-2 MB, with all enabled it goes up by around 12MB. If +12MB is acceptable, we could also always enable them by default as fully source maps do have some debugging benefits.