Fix profile page email display, respect settings #23747
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
fix-profile-page
branch
from
303dea2 to
c7422a7
Compare
zeripath
approved these changes
Mar 27, 2023
GiteaBot
added
the
lgtm/need 1
zeripath
added
type/bug
outdated/backport/v1.19
lunny
approved these changes
Mar 27, 2023
GiteaBot
added
the
lgtm/done
lunny
added
the
reviewed/wait-merge
wxiaoguang
changed the title
wxiaoguang
changed the title
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #23747 +/- ##
==========================================
- Coverage 47.14% 47.01% -0.13%
==========================================
Files 1149 1155 +6
Lines 151446 152496 +1050
==========================================
+ Hits 71397 71694 +297
- Misses 71611 72335 +724
- Partials 8438 8467 +29
... and 53 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
ping lg-tm |
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Mar 27, 2023
Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate` setting. * It doesn't make sense to show user's own E-mail to themself. * Always hide the E-mail if KeepEmailPrivate=true, then the user could know how their profile page looks like for others. * Revert the `setting.UI.ShowUserEmail` change from go-gitea#4981 . This setting is used to control the E-mail display, not only for the user list page. ps: the incorrect `<div .../>` tag on the profile page has been fixed by go-gitea#23748 together, so this PR becomes simpler.
lunny
pushed a commit
that referenced
this pull request
Mar 27, 2023
Backport #23747 by @wxiaoguang Always respect the `setting.UI.ShowUserEmail` and `KeepEmailPrivate` setting. * It doesn't make sense to show user's own E-mail to themself. * Always hide the E-mail if KeepEmailPrivate=true, then the user could know how their profile page looks like for others. * Revert the `setting.UI.ShowUserEmail` change from #4981 . This setting is used to control the E-mail display, not only for the user list page. ps: the incorrect `<div .../>` tag on the profile page has been fixed by #23748 together, so this PR becomes simpler. Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 28, 2023
* upstream/main: Fix issue due date edit toggle bug (go-gitea#23723) Fix profile page email display, respect settings (go-gitea#23747) Update Gitea version in docs (go-gitea#23755) Fix SVG close tag, improve commit graph page UI alignment (go-gitea#23751) Remove incorrect HTML self close tag (go-gitea#23748) Refactor repo commit list (go-gitea#23690) Fix tags view (go-gitea#23243) Add commit info in action page (go-gitea#23210) Use GitHub Actions compatible globbing for `branches`, `tag`, `path` filter (go-gitea#22804)
lunny
removed
the
reviewed/wait-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Always respect the
setting.UI.ShowUserEmailandKeepEmailPrivatesetting.setting.UI.ShowUserEmailchange from Show email if the authenticated user owns the profile page being requested for #4981 . This setting is used to control the E-mail display, not only for the user list page.ps: the incorrect
<div .../>tag on the profile page has been fixed by #23748 together, so this PR becomes simpler.