Skip to content

fix submodule is nil panic #23588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 20, 2023
Merged

fix submodule is nil panic #23588

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
162a263
fix submodule is nil panic
viletyy Mar 20, 2023
18485f5
Update services/repository/files/content.go
viletyy Mar 20, 2023
eae962d
Merge branch 'main' into submodule_nil_panic
KN4CK3R Mar 20, 2023
373d51a
Merge branch 'main' into submodule_nil_panic
techknowlogick Mar 20, 2023
532b1eb
Merge branch 'main' into submodule_nil_panic
jolheiser Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion services/repository/files/content.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,9 @@ func GetContents(ctx context.Context, repo *repo_model.Repository, treePath, ref
if err != nil {
return nil, err
}
contentsResponse.SubmoduleGitURL = &submodule.URL
if submodule != nil && submodule.URL != "" {
contentsResponse.SubmoduleGitURL = &submodule.URL
}
}
// Handle links
if entry.IsRegular() || entry.IsLink() {
Expand Down