Skip to content

Set opaque background on markup and images #23578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2023
Merged

Set opaque background on markup and images #23578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f36ae90
Set opaque background on markup and images
silverwind Mar 19, 2023
efdd9a4
Fix dropzone padding
silverwind Mar 19, 2023
98fc004
Merge branch 'main' into markdown-img-opaque
jolheiser Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions web_src/css/features/dropzone.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,3 +51,13 @@
.dropzone .dz-preview:hover .dz-image img {
filter: opacity(0.5) !important;
}

.dropzone-attachments .divider {
margin-top: 0 !important;
margin-bottom: 0 !important;
}

.dropzone-attachments .grid,
.dropzone-attachments .thumbnails {
padding: .5rem 1rem;
}
2 changes: 2 additions & 0 deletions web_src/css/markup/content.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
font-size: 16px;
line-height: 1.5 !important;
word-wrap: break-word;
background: var(--color-box-body);
Copy link
Contributor

@wxiaoguang wxiaoguang Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be inherit, then we do not need to fix various colors again and again.

Or just remove it? I can't see difference without this style.

image

Copy link
Member Author

@silverwind silverwind Mar 27, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

background does not inherit or cascade by default, so inherit would only inherit from the direct element parent, but in the release list we actually would want to inherit from body.

}

.markup.ui.segment {
Expand Down Expand Up @@ -308,6 +309,7 @@
.markup img {
max-width: 100%;
box-sizing: initial;
background: var(--color-box-body);
}

.markup img[align="right"] {
Expand Down
6 changes: 6 additions & 0 deletions web_src/css/repository.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2740,6 +2740,12 @@
width: 100% !important;
max-width: 100% !important;
margin: 0 !important;
padding: 0 !important;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also suggest to revert this change.

#23750 (comment)

It causes unnecessary overwriting problems.

}

.comment-body .markup {
padding: 1em;
border-radius: 0 0 var(--border-radius) var(--border-radius); /* don't render outside box */
}

.edit-label.modal .form .column,
Expand Down