Skip to content

Improve issues.LoadProject #22982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 20, 2023
Merged

Improve issues.LoadProject #22982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6e2a8aa
improve issues.LoadProject
yp05327 Feb 19, 2023
4265660
Merge branch 'main' into improve-issue-LoadProject
delvh Feb 20, 2023
a333371
Merge branch 'main' into improve-issue-LoadProject
delvh Feb 20, 2023
70a0518
Merge branch 'main' into improve-issue-LoadProject
lunny Feb 20, 2023
4cf00ce
Merge branch 'main' into improve-issue-LoadProject
lunny Feb 20, 2023
1760916
Merge branch 'main' into improve-issue-LoadProject
jolheiser Feb 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/issues/issue.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ func (issue *Issue) LoadAttributes(ctx context.Context) (err error) {
return
}

if err = issue.loadProject(ctx); err != nil {
if err = issue.LoadProject(ctx); err != nil {
return
}

Expand Down
6 changes: 1 addition & 5 deletions models/issues/issue_project.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,7 @@ import (
)

// LoadProject load the project the issue was assigned to
func (issue *Issue) LoadProject() (err error) {
return issue.loadProject(db.DefaultContext)
}

func (issue *Issue) loadProject(ctx context.Context) (err error) {
func (issue *Issue) LoadProject(ctx context.Context) (err error) {
if issue.Project == nil {
var p project_model.Project
if _, err = db.GetEngine(ctx).Table("project").
Expand Down