Skip to content

Fix README TOC links #22577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 31, 2023
Merged

Fix README TOC links #22577

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89030e9
headline link fix
crystalcommunication Jan 23, 2023
ef71b25
cleanup
crystalcommunication Jan 23, 2023
12b167f
Merge branch 'main' into fork/hl-fix
crystalcommunication Jan 29, 2023
d267f09
refactor this section
crystalcommunication Jan 29, 2023
400e5db
make fmt
crystalcommunication Jan 29, 2023
4bb7066
Merge branch 'main' into fork/hl-fix
crystalcommunication Jan 29, 2023
5c6281f
Merge branch 'main' into fork/hl-fix
crystalcommunication Jan 31, 2023
e7da7bf
merge comments
crystalcommunication Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions modules/markup/html.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,12 +358,19 @@ func postProcess(ctx *RenderContext, procs []processor, input io.Reader, output
}

func visitNode(ctx *RenderContext, procs, textProcs []processor, node *html.Node) {
// Add user-content- to IDs if they don't already have them
// Add user-content- to IDs and "#" links if they don't already have them
for idx, attr := range node.Attr {
if attr.Key == "id" && !(strings.HasPrefix(attr.Val, "user-content-") || blackfridayExtRegex.MatchString(attr.Val)) {
val := strings.TrimPrefix(attr.Val, "#")
notHasPrefix := !(strings.HasPrefix(val, "user-content-") || blackfridayExtRegex.MatchString(val))

if attr.Key == "id" && notHasPrefix {
node.Attr[idx].Val = "user-content-" + attr.Val
}

if attr.Key == "href" && strings.HasPrefix(attr.Val, "#") && notHasPrefix {
node.Attr[idx].Val = "#user-content-" + val
}

if attr.Key == "class" && attr.Val == "emoji" {
textProcs = nil
}
Expand Down