Skip to content

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Oct 19, 2022

Enable automaticLayout for monaco so it can reflow itself.

Fixes: #21508

@silverwind silverwind added this to the 1.18.0 milestone Oct 19, 2022
@silverwind silverwind added type/bug topic/ui Change the appearance of the Gitea UI backport/v1.17 backport/done All backports for this PR have been created labels Oct 19, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Oct 19, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 19, 2022
@silverwind
Copy link
Member Author

silverwind commented Oct 19, 2022

Got a small fix incoming to remove manual layout that has become unneccessary. Not worth to backport that but got to have on main branch to avoid double layout.

@silverwind
Copy link
Member Author

Added. Monaco layout still works fine on window resize and zoom.

@zeripath zeripath merged commit fe442db into go-gitea:main Oct 20, 2022
@silverwind silverwind deleted the automaticLayout branch October 20, 2022 06:36
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 21, 2022
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Check for valid user token in integration tests (go-gitea#21520)
  Ignore error when retrieving changed PR review files (go-gitea#21487)
  move invite by mail to services package (go-gitea#21513)
  Enable Monaco automaticLayout (go-gitea#21515)
  Update macOS install command (go-gitea#21507)
  [skip ci] Updated translations via Crowdin
  Suppress `ExternalLoginUserNotExist` error (go-gitea#21504)
  Revert increased width on pull pages (go-gitea#21470)
  Add team member invite by email (go-gitea#20307)
  Disable the 'Add File' button when not able to edit repo (go-gitea#21503)
  Remove vitest globals (go-gitea#21505)
  Fix branch dropdown shifting on page load (go-gitea#21428)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File editor lost view after zooming the page
5 participants