Refactor GetNextResourceIndex to make it work properly with transaction #21469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxiaoguang
force-pushed
the
fix-res-index
branch
2 times, most recently
from
a7a0756 to
a15c8f5
Compare
wxiaoguang
force-pushed
the
fix-res-index
branch
from
a15c8f5 to
bf48c5a
Compare
Gusted
approved these changes
Oct 15, 2022
GiteaBot
added
the
lgtm/need 1
|
Added tests. Ready for review & merge. |
lunny
reviewed
Oct 16, 2022
wxiaoguang
commented
Oct 16, 2022
lunny
approved these changes
Oct 16, 2022
GiteaBot
added
lgtm/done
|
Maybe we need to ensure |
Agree. Although the current approach also works without transaction (if there is no high concurrency access ...), I hope there is a mechanism to detect whether the context has an open transaction. If there is such mechanism, we can update the code to add the checks. |
Codecov Report
@@ Coverage Diff @@
## main #21469 +/- ##
==========================================
+ Coverage 47.43% 47.61% +0.18%
==========================================
Files 1020 1023 +3
Lines 139036 139354 +318
==========================================
+ Hits 65945 66359 +414
+ Misses 65100 64987 -113
- Partials 7991 8008 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
make L-G-T-M work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Oct 18, 2022
* upstream/main: (32 commits) inline gitpod image (go-gitea#21494) [skip ci] Updated translations via Crowdin Do not send notifications for draft releases (go-gitea#21451) Update reverse-proxies.zh-cn.md (go-gitea#21484) Docs: Update the feature comparison to other Git Hosting Services (go-gitea#20933) Add some api integration tests (go-gitea#18872) probe if sha before exec git (go-gitea#21467) Fix incorrect notification commit url (go-gitea#21479) Localize all timestamps (go-gitea#21440) [skip ci] Updated translations via Crowdin Add system setting table with cache and also add cache supports for user setting (go-gitea#18058) Return 404 when user is not found on avatar (go-gitea#21476) Enforce grouped NuGet search results (go-gitea#21442) Display total commit count in hook message (go-gitea#21400) Refactor GetNextResourceIndex to make it work properly with transaction (go-gitea#21469) Simplify fmt-check (go-gitea#21458) update current stable version 1.17.3 changelog [skip ci] Updated translations via Crowdin Fix mermaid-related bugs (go-gitea#21431) ...
lunny
added a commit
that referenced
this pull request
Nov 30, 2022
This PR is a follow up of #21469 Co-authored-by: Lauris BH <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related:
This PR uses a general and stable method to generate resource index (eg: Issue Index, PR Index)
If the code looks good, I can add more tests
ps: please skip the diff, only have a look at the new code. It's entirely re-written.