Skip to content

Remove unnecessary length check for repo's Description & Website #21194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2022
Merged

Remove unnecessary length check for repo's Description & Website #21194

merged 3 commits into from
Sep 18, 2022

Conversation

wxiaoguang
Copy link
Contributor

Follows #21119

The manual length check was as old as year 2014

59ffdbf6#diff-1851799b06733db4df3ec74385c1e8850ee5aedee70b8b55366910d22725eea8R374-R384

It doesn't make sense nowadays:

  1. The length check is already done by form's binding:MaxSize (then the manual check is unnecessary)
  2. The CreateRepository doesn't have such check (then the manual check is inconsistent)

So this PR removes these manual length checks.

@wxiaoguang wxiaoguang added type/refactoring Existing code has been cleaned up. There should be no new functionality. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels Sep 17, 2022
@wxiaoguang wxiaoguang added this to the 1.18.0 milestone Sep 17, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 17, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 17, 2022
@wxiaoguang wxiaoguang merged commit 395f65c into go-gitea:main Sep 18, 2022
@wxiaoguang wxiaoguang deleted the remove-unnecessary-length-check branch September 18, 2022 02:35
zjjhot added a commit to zjjhot/gitea that referenced this pull request Sep 19, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
15d11c1 
* upstream/main:
  Fix typo (go-gitea#21201)
  Remove unnecessary length check for repo's Description & Website (go-gitea#21194)
  Treat git object mode 40755 as directory (go-gitea#21195)
  Fix reaction of issues (go-gitea#21185)
  Fix CSV diff for added/deleted files (go-gitea#21189)
  Show label description in comments section (go-gitea#21156)
  Limit length of repo description and repo url input fields (go-gitea#21119)
@delvh delvh mentioned this pull request Sep 19, 2022
Closed
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@KN4CK3R KN4CK3R KN4CK3R approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lafriks @KN4CK3R @GiteaBot