Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 26, 2022

When reviewing #20925, found the bug that when you download archiver in a special commit UI, it will still download from default branch.

@lunny lunny added this to the 1.17.2 milestone Aug 26, 2022
@lunny lunny requested review from delvh, wxiaoguang and zeripath August 26, 2022 03:22
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Aug 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 26, 2022
@6543 6543 merged commit b0c6284 into go-gitea:main Aug 26, 2022
@6543
Copy link
Member

6543 commented Aug 26, 2022

please backport :)

@6543 6543 modified the milestones: 1.17.2, 1.18.0 Aug 26, 2022
@lunny lunny deleted the lunny/fix_dl_bug branch August 27, 2022 01:54
@lunny lunny added the backport/done All backports for this PR have been created label Aug 27, 2022
6543 pushed a commit that referenced this pull request Aug 28, 2022
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 28, 2022
zjjhot added a commit to zjjhot/gitea that referenced this pull request Aug 29, 2022
* upstream/main:
  [skip ci] Updated translations via Crowdin
  Add instructions how to add service dependencies (go-gitea#20968)
  Share HTML template renderers and create a watcher framework (go-gitea#20218)
  [skip ci] Updated licenses and gitignores
  [skip ci] Updated translations via Crowdin
  Change review buttons to icons to make space for text (go-gitea#20934)
  Fix download archiver of a commit (go-gitea#20962)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants