Skip to content

Check webhooks slice length before calling xorm #20642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 4, 2022
Merged

Check webhooks slice length before calling xorm #20642

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
24dab3a
Check webhooks slice length before calling xorm
gabriel-vasile Aug 2, 2022
5ae9cc4
Merge branch 'main' into webhook
lafriks Aug 3, 2022
40bf058
Merge branch 'main' into webhook
jolheiser Aug 3, 2022
6810172
Merge branch 'main' into webhook
lunny Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions models/webhook/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -399,6 +399,10 @@ func CreateWebhook(ctx context.Context, w *Webhook) error {

// CreateWebhooks creates multiple web hooks
func CreateWebhooks(ctx context.Context, ws []*Webhook) error {
// xorm returns err "no element on slice when insert" for empty slices.
if len(ws) == 0 {
return nil
}
for i := 0; i < len(ws); i++ {
ws[i].Type = strings.TrimSpace(ws[i].Type)
}
Expand Down