Skip to content

Conversation

techknowlogick
Copy link
Member

@techknowlogick techknowlogick commented Aug 2, 2022

Similar to how github profiles have badges/achievements, this adds the capabilities to Gitea to be able to utilize that in the future

image

@techknowlogick techknowlogick added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Aug 2, 2022
@techknowlogick techknowlogick added this to the 1.18.0 milestone Aug 2, 2022
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 2, 2022
@noerw
Copy link
Member

noerw commented Aug 2, 2022

I don't get it, whats the use case for this?

@techknowlogick
Copy link
Member Author

I don't get it, whats the use case for this?

@noerw for community instances, where they may wish to "award" some badge for certain situations.

@noerw
Copy link
Member

noerw commented Aug 4, 2022

I don't get it, whats the use case for this?

@noerw for community instances, where they may wish to "award" some badge for certain situations.

Sorry to be that guy, but this feels very feature-creepy to me.
Gamification as a network effect multiplier kinda makes sense for a platform like GitHub, but should this really be a Gitea feature? (yes I'm biased; i don't like gamification).

Currently this PR is rather slim LoC-wise, but until it's a working feature (configure badges via UI or config file, updating badges via cron task or adding hooks into every other route), I'd estimate some extra 500LoC, lower bound.

@lafriks
Copy link
Member

lafriks commented Aug 4, 2022

Badges can be useful also in private instances to motivate developers etc
I don't think we need UI in gitea to manage that, only API. Service to manage badges and add for users can be developed outside of Gitea core.

@noerw
Copy link
Member

noerw commented Aug 4, 2022

Badges can be useful also in private instances to motivate developers etc

Developers do meaningful work when they are intrinsically motivated, not by some made up metric or status icon. But what do I know.

I don't think we need UI in gitea to manage that, only API. Service to manage badges and add for users can be developed outside of Gitea core.

Doing hundreds of API calls to check if a badge should be applied seems more than wasteful to me.

I'll shut up, seems like I'm in the minority here

@silverwind
Copy link
Member

silverwind commented Aug 4, 2022

It's probably not the best way to reward developers, but I see no problem in at least supporting it on a invisible api- or even database-only level.

Copy link
Member

@a1012112796 a1012112796 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wonder how to add badge?

@lunny
Copy link
Member

lunny commented Aug 17, 2022

Could you put a screenshot?

@techknowlogick
Copy link
Member Author

Could you put a screenshot?

updated with a screenshot

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Aug 17, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Aug 17, 2022
@lafriks lafriks merged commit d8e6c99 into go-gitea:main Aug 17, 2022
@lafriks
Copy link
Member

lafriks commented Aug 17, 2022

Would be nice to have followup PR to add API that would be accessible only for admin to define badges and add user badges

@bauermarkus
Copy link

Is this released? I haven't found it on the release notes

@techknowlogick
Copy link
Member Author

@bauermarkus yup, it's in 1.18, however it's just the absolute base code needed to present badges stored in the DB to show on user's profiles. I have a followup PR where you can manage badges with the API.

@go-gitea go-gitea locked and limited conversation to collaborators Mar 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.