Allow non-semver packages in the Conan package registry (#20412) #20523
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A lot of existing packages do not conform to SemVer, yet, they should be allowed in the Conan package registry as-is. To achieve this, remove the SemVer check from `NewRecipeReference`, and replace it with a simple empty string check. A unit test with a non-semver version is also included. Fixes go-gitea#20405. Signed-off-by: Gergely Nagy <[email protected]> Co-authored-by: KN4CK3R <[email protected]>
jolheiser
approved these changes
Jul 28, 2022
GiteaBot
added
the
lgtm/need 1
Gusted
approved these changes
Jul 28, 2022
GiteaBot
added
lgtm/done
6543
added
the
issue/regression
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #20412
A lot of existing packages do not conform to SemVer, yet, they should be allowed
in the Conan package registry as-is. To achieve this, remove the SemVer check
from
NewRecipeReference, and replace it with a simple empty string check.A unit test with a non-semver version is also included.
Fixes #20405.
Signed-off-by: Gergely Nagy [email protected]
Co-authored-by: KN4CK3R [email protected]