Skip to content

Conversation

KN4CK3R
Copy link
Member

@KN4CK3R KN4CK3R commented Jul 27, 2022

Backport #20492

* Hide internal versions from most searches.

* Added test.
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jul 27, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 27, 2022
@lafriks
Copy link
Member

lafriks commented Jul 27, 2022

Lint fails

@KN4CK3R
Copy link
Member Author

KN4CK3R commented Jul 27, 2022

The lint reveals why this problem occurred in the first place. #18064 made the IsInternal optional which resulted in the wrong API result. So this backport is not needed because the error is only in 1.18.

@KN4CK3R KN4CK3R closed this Jul 27, 2022
@KN4CK3R KN4CK3R deleted the backport-fix-20491 branch August 5, 2022 09:41
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/packages type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants