Skip to content

Init popup for new code comment #20234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 5, 2022
Merged

Init popup for new code comment #20234

merged 2 commits into from
Jul 5, 2022

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jul 5, 2022

Init popup for new code comment
33d5528 
- Initialize the popup for the tooltip inside the new code comment.
- This works and is good enough to have this issue fixed for 1.17
- Resolves go-gitea#20068
@Gusted Gusted added this to the 1.18.0 milestone Jul 5, 2022
@Gusted Gusted added type/bug skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/v1.17 labels Jul 5, 2022
Gusted pushed a commit to Gusted/gitea that referenced this pull request Jul 5, 2022
Init popup for new code comment (go-gitea#20234)
18eb5fe 
- Backport go-gitea#20234
  - Initialize the popup for the tooltip inside the new code comment.
  - This works and is good enough to have this issue fixed for 1.17
  - Resolves go-gitea#20068
@Gusted Gusted mentioned this pull request Jul 5, 2022
Merged
@Gusted Gusted added the backport/done All backports for this PR have been created label Jul 5, 2022
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@c174bdc). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main   #20234   +/-   ##
=======================================
  Coverage        ?   46.93%           
=======================================
  Files           ?      973           
  Lines           ?   134917           
  Branches        ?        0           
=======================================
  Hits            ?    63319           
  Misses          ?    63841           
  Partials        ?     7757

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c174bdc...33d5528. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 5, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 5, 2022
@zeripath zeripath merged commit ed13d7a into go-gitea:main Jul 5, 2022
zeripath pushed a commit that referenced this pull request Jul 5, 2022
Init popup for new code comment (#20234) (#20235)
f42fc3b 
- Backport #20234
 
  - Initialize the popup for the tooltip inside the new code comment.
  - This works and is good enough to have this issue fixed for 1.17
 
Fix #20068
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jul 7, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
310604f 
* upstream/main:
  Modify milestone search keywords to be case insensitive (go-gitea#20266)
  Fix toolip on mobile notification bell (go-gitea#20270)
  Allow RSA 2047 bit keys (go-gitea#20272)
  Refix notification bell placement (go-gitea#20251)
  Bump mermaid from 9.1.1 to 9.1.2 (go-gitea#20256)
  EscapeFilter the group dn membership (go-gitea#20200)
  Only show Followers that current user can access (go-gitea#20220)
  Init popup for new code comment (go-gitea#20234)
  Bypass Firefox (iOS) bug (go-gitea#20244)
  Adjust max-widths for the repository file table (go-gitea#20243)
  Display full name (go-gitea#20171)
  Adjust class for mobile has the problem of double small bells (go-gitea#20236)
  Adjust template for go-gitea#20069 smallbell (go-gitea#20108)
  Add integration tests for the Gitea migration form (go-gitea#20121)
  Allow dev i18n to be more concurrent (go-gitea#20159)
  Allow enable LDAP source and disable user sync via CLI (go-gitea#20206)
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this pull request Jul 9, 2022
@dineshsalunke
Init popup for new code comment (go-gitea#20234)
2b86075 
- Initialize the popup for the tooltip inside the new code comment.
- This works and is good enough to have this issue fixed for 1.17


Fix go-gitea#20068
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
Init popup for new code comment (go-gitea#20234)
2b3a1a8 
- Initialize the popup for the tooltip inside the new code comment.
- This works and is good enough to have this issue fixed for 1.17


Fix go-gitea#20068
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

@delvh delvh delvh approved these changes

+1 more reviewer

@zeripath zeripath zeripath approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

Pending Tooltip Doesn't Show For New Code Comments
6 participants
@Gusted @codecov-commenter @zeripath @wxiaoguang @delvh @GiteaBot