Fix cli command restore-repo: "units" should be parsed as cli.String #20183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ice, to match the old behavior and match the dump-repo's behavior
wxiaoguang
changed the title
wxiaoguang
added
backport/done
delvh
approved these changes
Jun 30, 2022
GiteaBot
added
the
lgtm/need 1
silverwind
approved these changes
Jul 1, 2022
GiteaBot
added
lgtm/done
wxiaoguang
added
the
skip-changelog
|
LGTM |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jul 1, 2022
* upstream/main: Fix cli command restore-repo: "units" should be splitted to string slice, to match the old behavior and match the dump-repo's behavior (go-gitea#20183) [skip ci] Updated translations via Crowdin Fix `dump-repo` git init, fix wrong error type for NullDownloader (go-gitea#20182) Check if project has the same repository id with issue when assign project to issue (go-gitea#20133) [skip ci] Updated translations via Crowdin
6543
pushed a commit
that referenced
this pull request
Jul 1, 2022
vsysoev
pushed a commit
to IntegraSDL/gitea
that referenced
this pull request
Aug 10, 2022
…ice, to match the old behavior and match the dump-repo's behavior (go-gitea#20183)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "units" should be splitted to string slice, to match the old behavior and match the
dump-repo's behavior https://github.com/go-gitea/gitea/blob/main/cmd/dump_repo.go#L129-L130Before, the #19953 was misled by #19935 (sorry that I didn't find the problem at that time, just followed these 3 LGTMs).
This PR should make everything correct and consistent, and more stable by trimming / checking