Skip to content

Release page show all tags in compare dropdown #20070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 21, 2022
Merged

Release page show all tags in compare dropdown #20070

merged 2 commits into from
Jun 21, 2022

Conversation

6543
Copy link
Member

@6543 6543 commented Jun 21, 2022

this fix #19936 but long term we should limit and use keyword to filter ...

@6543 6543 added this to the 1.18.0 milestone Jun 21, 2022
@6543 6543 added the type/bug label Jun 21, 2022
@6543 6543 mentioned this pull request Jun 21, 2022
Closed
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 21, 2022
@6543
Release page show all tags in compare dropdown (go-gitea#20070)
dc4c5c5
@6543 6543 mentioned this pull request Jun 21, 2022
Merged
6543 added a commit to 6543-forks/gitea that referenced this pull request Jun 21, 2022
@6543
Release page show all tags in compare dropdown (go-gitea#20070)
c4666d5
@6543 6543 mentioned this pull request Jun 21, 2022
Merged
@6543 6543 added the backport/done All backports for this PR have been created label Jun 21, 2022
@6543
Copy link
Member Author

6543 commented Jun 21, 2022

-> #20071 & #20072

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 21, 2022
Gusted
Gusted reviewed Jun 21, 2022
View reviewed changes
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2022
@6543 6543 merged commit f6db650 into go-gitea:main Jun 21, 2022
@6543 6543 deleted the fix_release-compare-tags branch June 21, 2022 17:42
@zeripath
Copy link
Contributor

zeripath commented Jun 21, 2022 •
edited
Loading

This is really not an ideal fix...

We need to create/use a branch listing API instead just getting all of the tags but this will work for the moment...

zeripath pushed a commit that referenced this pull request Jun 21, 2022
@6543
Release page show all tags in compare dropdown (#20070) (#20072)
29ac316 
Backport #20070 

Just get all tags when creating the compare dropdown.

Fix #19936
zeripath pushed a commit that referenced this pull request Jun 21, 2022
@6543
Release page show all tags in compare dropdown (#20070) (#20071)
51db7b0 
Backport #20070 

Just get all tags when creating the compare dropdown. (Also updates the changelog.)
Fix #19936
@6543
Copy link
Member Author

6543 commented Jun 21, 2022 •
edited
Loading

@zeripath before the refactor (#16897) it was this way :D ...
anyway I created an issue #20073 to track this

zjjhot added a commit to zjjhot/gitea that referenced this pull request Jun 22, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c6aea50 
* giteaofficial/main:
  Update permissions.en-us.md (go-gitea#20075)
  Changelog for 1.16.9 (go-gitea#20059) (go-gitea#20063)
  Release page show all tags in compare dropdown (go-gitea#20070)
  docs: Mention file extension for issue_template directory (go-gitea#20057)
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@6543
Release page show all tags in compare dropdown (go-gitea#20070)
6256c99 
address go-gitea#19936
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

+1 more reviewer

@Gusted Gusted Gusted approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging this pull request may close these issues.

Compare Releases 10 tags only
5 participants
@6543 @zeripath @lunny @Gusted @GiteaBot