Skip to content

Fix a JS error in initRepoCommitLastCommitLoader's entryMap #19996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 17, 2022
Merged

Fix a JS error in initRepoCommitLastCommitLoader's entryMap #19996

merged 1 commit into from
Jun 17, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Jun 17, 2022 •
edited
Loading

The problem is that there are unrecognized tr rows in response, and the JS code didn't handle it correctly.

Close #19995

@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Jun 17, 2022
@wxiaoguang wxiaoguang mentioned this pull request Jun 17, 2022
Closed
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 17, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 17, 2022
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 17, 2022
@wxiaoguang wxiaoguang marked this pull request as draft June 17, 2022 08:58
@wxiaoguang wxiaoguang added the pr/wip This PR is not ready for review label Jun 17, 2022
@wxiaoguang
Copy link
Contributor Author

Wait for some more time, I think I get some new clues.

@wxiaoguang wxiaoguang self-assigned this Jun 17, 2022
@wxiaoguang wxiaoguang force-pushed the fix-commit-js-error branch from 2c5f69d to 5cc1c91 Compare June 17, 2022 09:11
@wxiaoguang wxiaoguang removed their assignment Jun 17, 2022
@wxiaoguang wxiaoguang marked this pull request as ready for review June 17, 2022 09:11
@wxiaoguang
Copy link
Contributor Author

Root case is clear, fine tuned. (well, not changed too much as before)

@wxiaoguang wxiaoguang added type/bug and removed pr/wip This PR is not ready for review labels Jun 17, 2022
@Fogapod
Copy link
Contributor

Fogapod commented Jun 17, 2022

These changes worked for me. Commits are shown as ..., after a few seconds they get updated with proper messages and dates

@wxiaoguang wxiaoguang merged commit 719eb4a into go-gitea:main Jun 17, 2022
@wxiaoguang wxiaoguang deleted the fix-commit-js-error branch June 17, 2022 09:44
@wxiaoguang wxiaoguang mentioned this pull request Jun 17, 2022
Merged
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
@wxiaoguang
Fix a JS error in initRepoCommitLastCommitLoader's entryMap (go-gitea…
6c7c8e9 
…#19996)
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@wxiaoguang @AbdulrhmnGhanem
Fix a JS error in initRepoCommitLastCommitLoader's entryMap (go-gitea…
6f31eac 
…#19996)
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
5 participants
@wxiaoguang @Fogapod @lunny @delvh @GiteaBot