Skip to content

Conversation

a1012112796
Copy link
Member

fix #19970

by the way, fix some error response about
protected tags.

fix go-gitea#19970

by the way, fix some error response about
protected tags.

Signed-off-by: a1012112796 <[email protected]>
@lunny lunny added this to the 1.17.0 milestone Jun 16, 2022
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Jun 16, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Jun 16, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19985 (3ec96ad) into main (6473bd3) will decrease coverage by 0.41%.
The diff coverage is 36.68%.

@@            Coverage Diff             @@
##             main   #19985      +/-   ##
==========================================
- Coverage   47.36%   46.94%   -0.42%     
==========================================
  Files         967      968       +1     
  Lines      134126   134230     +104     
==========================================
- Hits        63532    63019     -513     
- Misses      62868    63498     +630     
+ Partials     7726     7713      -13     
Impacted Files Coverage Δ
cmd/doctor.go 0.00% <0.00%> (ø)
cmd/hook.go 7.11% <0.00%> (ø)
modules/markup/console/console.go 38.46% <ø> (+2.74%) ⬆️
modules/markup/csv/csv.go 29.16% <ø> (+0.88%) ⬆️
modules/markup/external/external.go 1.28% <0.00%> (-0.04%) ⬇️
modules/markup/markdown/markdown.go 48.64% <ø> (-10.69%) ⬇️
modules/markup/orgmode/orgmode.go 52.88% <ø> (+0.99%) ⬆️
modules/setting/markup.go 4.90% <0.00%> (-0.72%) ⬇️
routers/api/v1/repo/release.go 61.72% <0.00%> (-0.97%) ⬇️
routers/web/repo/branch.go 56.41% <0.00%> (-0.92%) ⬇️
... and 53 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 89b0aac...3ec96ad. Read the comment docs.

@6543 6543 merged commit e3e06d1 into go-gitea:main Jun 16, 2022
@6543
Copy link
Member

6543 commented Jun 16, 2022

do we have protected branches in v1.16.x ? - if so we should backport :)

@a1012112796 a1012112796 deleted the fix-protected-tag branch June 17, 2022 16:17
a1012112796 added a commit to a1012112796/gitea that referenced this pull request Jun 17, 2022
fix go-gitea#19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <[email protected]>
@a1012112796 a1012112796 added backport/done All backports for this PR have been created backport/v1.16 labels Jun 17, 2022
zeripath pushed a commit that referenced this pull request Jun 17, 2022
fix #19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this pull request Jun 20, 2022
## [1.16.9](https://github.com/go-gitea/gitea/releases/tag/1.16.9) - 2022-06-20

* BUGFIXES
  * Fix permission check for delete tag (go-gitea#19985) (go-gitea#20001)
  * Only log non ErrNotExist errors in git.GetNote  (go-gitea#19884) (go-gitea#19905)
  *  Use exact search instead of fuzzy search for branch filter dropdown (go-gitea#19885) (go-gitea#19893)
  * Set Setpgid on child git processes (go-gitea#19865) (go-gitea#19881)
  * Import git from alpine 3.16 repository as 2.30.4 is needed for `safe.directory = '*'` to work but alpine 3.13 has 2.30.3 (go-gitea#19876)
  * Ensure responses are context.ResponseWriters (go-gitea#19843) (go-gitea#19859)
  * Fix count bug (go-gitea#19850)
  * Fix raw endpoint PDF file headers (go-gitea#19825) (go-gitea#19826)
  * Make WIP prefixes case insensitive, e.g. allow `Draft` as a WIP prefix (go-gitea#19780) (go-gitea#19811)
  * Fix NotificationUnreadCount (go-gitea#19802)
  * Prevent NPE when cache service is disabled (go-gitea#19703) (go-gitea#19783)
  * Detect truncated utf-8 characters at the end of content as still representing utf-8 (go-gitea#19773) (go-gitea#19774)
  * Fix doctor pq: syntax error at or near "." quote user table name (go-gitea#19765) (go-gitea#19770)
  * Fix bug (go-gitea#19757)

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this pull request Jun 20, 2022
vsysoev pushed a commit to IntegraSDL/gitea that referenced this pull request Aug 10, 2022
fix go-gitea#19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
fix go-gitea#19970

by the way, fix some error response about protected tags.

Signed-off-by: a1012112796 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Protected Tags dont protect if delete happens via WebUI
6 participants