Skip to content

Call MultipartForm.RemoveAll when request finishes #19606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 5, 2022
Merged

Call MultipartForm.RemoveAll when request finishes #19606

merged 3 commits into from
May 5, 2022

Conversation

wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented May 4, 2022 •
edited
Loading

Fix #19595

Golang's mime/multipart/formdata.go caches files on disk, these temp files should be removed by caller when request finishes if we cloned the http.Request

Tested and work as expected

@wxiaoguang wxiaoguang added this to the 1.17.0 milestone May 4, 2022
@wxiaoguang wxiaoguang mentioned this pull request May 4, 2022
Merged
@wxiaoguang wxiaoguang added skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. backport/done All backports for this PR have been created backport/v1.16 labels May 4, 2022
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label May 5, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 5, 2022
@6543
Copy link
Member

6543 commented May 5, 2022

🚀

@6543 6543 merged commit 04fc4b7 into go-gitea:main May 5, 2022
6543 pushed a commit that referenced this pull request May 5, 2022
@wxiaoguang
Call MultipartForm.RemoveAll when request finishes (#19606) (#19607)
46637b1
zjjhot added a commit to zjjhot/gitea that referenced this pull request May 5, 2022
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
eef822a 
* giteaofficial/main:
  Call MultipartForm.RemoveAll when request finishes (go-gitea#19606)
  Remove `RequireHighlightJS` field, update plantuml example. (go-gitea#19615)
  [skip ci] Updated translations via Crowdin
  PullService lock via pullID (go-gitea#19520)
@wxiaoguang wxiaoguang deleted the fix-large-form-tmp-file branch May 5, 2022 15:12
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
@wxiaoguang @AbdulrhmnGhanem
Call MultipartForm.RemoveAll when request finishes (go-gitea#19606)
bff5ecd
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny lunny approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.17.0
Development

Successfully merging this pull request may close these issues.

Gitea leaves large uploads in /tmp
5 participants
@wxiaoguang @6543 @lunny @delvh @GiteaBot