Skip to content

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 26, 2022

Split readme file render function.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Apr 26, 2022
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 26, 2022
@lunny lunny force-pushed the lunny/refactor_readme branch from 2abcb0b to 5795e5b Compare April 26, 2022 16:47
@6543 6543 added this to the 1.17.0 milestone Apr 26, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #19502 (5795e5b) into main (ebb2396) will increase coverage by 0.01%.
The diff coverage is 47.22%.

@@            Coverage Diff             @@
##             main   #19502      +/-   ##
==========================================
+ Coverage   47.42%   47.43%   +0.01%     
==========================================
  Files         951      950       -1     
  Lines      132360   132314      -46     
==========================================
- Hits        62767    62760       -7     
+ Misses      62032    61994      -38     
+ Partials     7561     7560       -1     
Impacted Files Coverage Δ
models/issue_label.go 68.46% <0.00%> (+0.44%) ⬆️
routers/web/events/events.go 0.00% <ø> (ø)
routers/web/repo/cherry_pick.go 0.00% <0.00%> (ø)
routers/web/repo/commit.go 25.53% <0.00%> (-0.64%) ⬇️
routers/web/repo/issue_stopwatch.go 39.24% <0.00%> (-6.35%) ⬇️
routers/web/repo/view.go 40.48% <42.60%> (+0.46%) ⬆️
modules/eventsource/manager_run.go 68.00% <50.00%> (-6.55%) ⬇️
models/issue_stopwatch.go 55.31% <52.38%> (-0.37%) ⬇️
services/webhook/webhook.go 51.70% <59.25%> (+2.88%) ⬆️
routers/api/v1/repo/commits.go 73.47% <60.00%> (-0.57%) ⬇️
... and 30 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cc8aed...5795e5b. Read the comment docs.

@techknowlogick techknowlogick merged commit d71df01 into go-gitea:main Apr 26, 2022
@lunny lunny deleted the lunny/refactor_readme branch April 27, 2022 01:57
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 28, 2022
* giteaofficial/main: (21 commits)
  Prevent intermittent race in attribute reader close (go-gitea#19537)
  Make repository file list useable on mobile (go-gitea#19515)
  Update image URL for Discord webhook (go-gitea#19536)
  [skip ci] Updated translations via Crowdin
  Fix 64-bit atomic operations on 32-bit machines (go-gitea#19531)
  Fix `upgrade.sh` script error with `su -c` (go-gitea#19483)
  When view _Siderbar or _Footer, just display once (go-gitea#19501)
  Fix migrate release from github (go-gitea#19510)
  Prevent dangling archiver goroutine (go-gitea#19516)
  Don't let repo clone URL overflow (go-gitea#19517)
  Add commit status popup to issuelist (go-gitea#19375)
  Disable unnecessary GitHooks elements (go-gitea#18485)
  Disable unnecessary GitHooks elements
  Improve dashboard's repo list performance (go-gitea#18963)
  By default force vertical tabs on mobile (go-gitea#19486)
  Refactor readme file renderer (go-gitea#19502)
  Allow package dump skipping (go-gitea#19506)
  Unset git author/committer variables when running integration tests (go-gitea#19512)
  Allow commit status popup on /pulls page (go-gitea#19507)
  Use router param for filepath in GetRawFile (go-gitea#19499)
  ...
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 24, 2022
* Refactor readme file renderer

* improve
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants