RepoAssignment ensure to close before overwrite #19449
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6543
changed the title
6543
commented
Apr 20, 2022
GiteaBot
added
the
lgtm/need 2
delvh
approved these changes
Apr 21, 2022
GiteaBot
added
lgtm/need 1
Co-authored-by: delvh <[email protected]>
wxiaoguang
reviewed
Apr 21, 2022
wxiaoguang
reviewed
Apr 21, 2022
6543
commented
Apr 21, 2022
|
@wxiaoguang added some smal refactoring - I wont backport this but its good to have in main |
wxiaoguang
approved these changes
Apr 21, 2022
GiteaBot
added
lgtm/done
Codecov Report
@@ Coverage Diff @@
## main #19449 +/- ##
=======================================
Coverage ? 47.40%
=======================================
Files ? 951
Lines ? 132339
Branches ? 0
=======================================
Hits ? 62732
Misses ? 62051
Partials ? 7556
Continue to review full report at Codecov.
|
6543
added
the
type/refactoring
|
current conclusion ... we need a unified way to inject and get gitRepo from context e.g. either use git.RepositoryFromContextOrOpen() or pass gitRepo as argument, whatever simplify the code in the specific case best |
|
🚀 |
This was referenced Apr 21, 2022
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Apr 21, 2022
* giteaofficial/main: Fix logging of Transfer API (go-gitea#19456) RepoAssignment ensure to close before overwrite (go-gitea#19449) node12 is EOL (go-gitea#19451) Add Changelog v1.16.6 (go-gitea#19339) (go-gitea#19450) Fix DELETE request for non-existent public key (go-gitea#19443) [skip ci] Updated translations via Crowdin Don't panic on `ErrEmailInvalid` (go-gitea#19441)
6543
added a commit
that referenced
this pull request
Apr 21, 2022
6543
added a commit
that referenced
this pull request
Apr 25, 2022
#19461) as per #19449 (comment) pass gitRepo down to GetRawDiff, since its used for main repo and wiki
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
* check if GitRepo already open and close if * only run RepoAssignment once * refactor context helper for api to open GitRepo
AbdulrhmnGhanem
pushed a commit
to kitspace/gitea
that referenced
this pull request
Aug 24, 2022
go-gitea#19461) as per go-gitea#19449 (comment) pass gitRepo down to GetRawDiff, since its used for main repo and wiki
This was referenced Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as title - to prevent "pipe leaks"