When dumping trim the standard suffices instead of a random suffix (#19440) #19447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o-gitea#19440) * When dumping trim the standard suffices instead of a random suffix Instead of using the `path.Ext()` to trim the last "extension" suffix, just iterate through the supported suffices and trim those. Fix go-gitea#19424 Signed-off-by: Andrew Thornton <[email protected]> * fix enum with to have correct supported types only Co-authored-by: 6543 <[email protected]>
Gusted
approved these changes
Apr 20, 2022
GiteaBot
added
the
lgtm/need 1
zeripath
approved these changes
Apr 20, 2022
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #19440
Instead of using the
path.Ext()to trim the last "extension" suffix, just iteratethrough the supported suffices and trim those.
Fix #19424
Co-authored-by: 6543 [email protected]
Signed-off-by: Andrew Thornton [email protected]