Allow users to self-request a PR review #19030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The review request feature was added in go-gitea#10756, where the doer got explicitly excluded from available reviewers. I don't see a functionality or security related reason to forbid this case. As shown by GitHubs implementation, it may be useful to self-request a review, to be reminded oneselves about reviewing, while communicating to team mates that a review is missing.
delvh
approved these changes
Mar 8, 2022
GiteaBot
added
the
lgtm/need 1
Co-authored-by: delvh <[email protected]>
6543
reviewed
Mar 8, 2022
|
Also, I think this should be backported. |
6543
approved these changes
Mar 8, 2022
GiteaBot
added
lgtm/done
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Mar 9, 2022
* giteaofficial/main: Add button for issue deletion (go-gitea#19032) Fix script compatiable with OpenWrt (go-gitea#19000) Allow users to self-request a PR review (go-gitea#19030) Fix wrong scopes caused by empty scope input (go-gitea#19029) Feature: show issue assignee on project board (go-gitea#15232) bump go deps (go-gitea#19021) Don't show context cancelled errors in attribute reader (go-gitea#19006) Set `rel="nofollow noindex"` on new issue links (go-gitea#19023) update to correct stable version
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
The review request feature was added in go-gitea#10756, where the doer got explicitly excluded from available reviewers. I don't see a functionality or security related reason to forbid this case. As shown by GitHubs implementation, it may be useful to self-request a review, to be reminded oneselves about reviewing, while communicating to team mates that a review is missing. Co-authored-by: delvh <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The review request feature was added in #10756, where the doer got explicitly excluded from available reviewers.
I can't see a security or functionality related reason to forbid this case.
As shown by GitHub's implementation, it may be useful to self-request a review, to remind yourself about a later review, while communicating to team mates that a review is missing.