Fix 'make fmt-check'

[silverwind]

make fmt-check did not run all commands that make fmt did, resulting
in missed diffs. Fix that by just depending on the fmt target.

Includes: #18633

[silverwind]

There is one difference in the arguments, gitea-fmt took -d in fmt-check while fmt took -w, so I'm not sure whether this fix is correct. cc: @6543.

[zeripath]

https://pkg.go.dev/cmd/gofmt

-d
	Do not print reformatted sources to standard output.
	If a file's formatting is different than gofmt's, print diffs
	to standard output.

[zeripath]

The problem is that gitea-fmt doesn't properly support the -d as far as I can see

[silverwind]

I think my version was fine. We want it to just alter the files in-place in both cases. No need for duplicate code that risk going out of sync on careless edits.

[zeripath]

I'm gonna merge this in to your other PR.

[silverwind]

Can you make it so fmt-check still depends on fmt?

[zeripath]

Nope they're calling different args - one is doing diff and one is writing files.

[silverwind]

Seems a bit pointless to not just rely on git diff :)

[zeripath]

then fmt-check is dependent on the the status of your git index which is very non-ideal.

[silverwind]

Does it matter when the target realistically is only triggered on CI where index is clean?

[zeripath]

It is not only triggered on CI.