Skip to content

Conversation

Gusted
Copy link
Contributor

@Gusted Gusted commented Jan 23, 2022

  • Don't underline the commit status icon on hover, as it isn't a link per-se.

Before:
image

After:
image

- Don't underline the commit status icon, as it isn't a link per-se.
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2022

Codecov Report

Merging #18372 (4100eed) into main (3349fd8) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #18372      +/-   ##
==========================================
+ Coverage   46.03%   46.05%   +0.02%     
==========================================
  Files         840      840              
  Lines       92856    92856              
==========================================
+ Hits        42746    42765      +19     
+ Misses      43323    43307      -16     
+ Partials     6787     6784       -3     
Impacted Files Coverage Δ
modules/queue/workerpool.go 57.99% <0.00%> (-0.63%) ⬇️
services/pull/pull.go 42.39% <0.00%> (-0.41%) ⬇️
models/issue_comment.go 54.86% <0.00%> (+0.56%) ⬆️
modules/queue/queue_disk_channel.go 63.86% <0.00%> (+1.48%) ⬆️
modules/process/manager.go 82.94% <0.00%> (+1.55%) ⬆️
modules/queue/queue_bytefifo.go 53.63% <0.00%> (+1.81%) ⬆️
modules/git/repo_base_nogogit.go 75.60% <0.00%> (+2.43%) ⬆️
modules/git/utils.go 70.83% <0.00%> (+2.77%) ⬆️
modules/queue/queue_channel.go 82.60% <0.00%> (+3.26%) ⬆️
modules/charset/charset.go 75.75% <0.00%> (+4.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3349fd8...4100eed. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 23, 2022
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 23, 2022
@silverwind
Copy link
Member

Should add the selector to the existing rule here:

a.label,
.repository-menu a,
.ui.search .results a,
.ui .menu a,
.ui.cards a.card,
.issue-keyword a {
text-decoration: none !important;
}

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jan 23, 2022
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 23, 2022
@zeripath zeripath merged commit e36f0b6 into go-gitea:main Jan 23, 2022
@Gusted Gusted deleted the non-hover-ci branch January 23, 2022 19:11
zjjhot pushed a commit to zjjhot/gitea that referenced this pull request Jan 24, 2022
* 'main' of https://github.com/go-gitea/gitea:
  [skip ci] Updated translations via Crowdin
  Fix partial cloning a repo (go-gitea#18373)
  Switch to non-deprecation setting (go-gitea#18358)
  Update the SSH passthrough documentation (go-gitea#18366)
  Don't underline commit status icon on hover (go-gitea#18372)
Chianina pushed a commit to Chianina/gitea that referenced this pull request Mar 28, 2022
- Don't underline the commit status icon, as it isn't a link per-se.
@wxiaoguang wxiaoguang added this to the 1.17.0 milestone Mar 29, 2022
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants