Make AvatarRenderedSizeFactor configurable and set it to 3 #17951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, the devices with pixel ratio > 3 from the link above:
|
GiteaBot
added
the
lgtm/need 2
silverwind
force-pushed
the
avatar-factor-3
branch
from
21687b7 to
59d80d0
Compare
|
@silverwind silverwind#1 will make this a configurable option which should make @strk happy |
|
Yes I'm happy with configurable, and merged your PR to mine (#17422) |
zeripath
approved these changes
Dec 15, 2021
GiteaBot
added
lgtm/need 1
|
Merged and did some minor description adjustments. Default is |
wxiaoguang
approved these changes
Dec 16, 2021
GiteaBot
added
lgtm/done
silverwind
changed the title
Save a bit of bandwidth by only requesting 3-times the rendered avatar size. Factor 4 is only really beneficial on a handful of mobile phones and I don't think they are the primary device we design for. Configurability contributed by zeripath. Fixes: go-gitea#17422 Fixes: go-gitea#16287
silverwind
force-pushed
the
avatar-factor-3
branch
from
6cb5373 to
4761cf5
Compare
|
PR title and commit description updated. |
|
CI failed is unrelated. |
Merged
Chianina
pushed a commit
to Chianina/gitea
that referenced
this pull request
Mar 28, 2022
…17951) Save a bit of bandwidth by only requesting 3-times the rendered avatar size. Factor 4 is only really beneficial on a handful of mobile phones and I don't think they are the primary device we design for. Configurability contributed by zeripath. Fixes: go-gitea#17422 Fixes: go-gitea#16287 Co-authored-by: wxiaoguang <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save a bit of bandwidth by only requesting 3-times the rendered avatar size. Factor 4 is only really beneficial on a handful of mobile phones and I don't think they are the primary device we design for.
Fixes: #17422
Fixes: #16287