Skip to content

Remove unused user paramater #17723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 19, 2021
Merged

Remove unused user paramater #17723

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca32a34
Remove unused `user` paramater
Nov 18, 2021
3b94c09
Merge branch 'main' into remove-unused-user
techknowlogick Nov 19, 2021
0d23275
Merge branch 'main' into remove-unused-user
wxiaoguang Nov 19, 2021
0256613
Merge branch 'main' into remove-unused-user
lunny Nov 19, 2021
9a9529c
Merge branch 'main' into remove-unused-user
techknowlogick Nov 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions routers/web/repo/compare.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,7 @@ func ParseCompareInfo(ctx *context.Context) *CompareInfo {
if canRead {
ctx.Data["RootRepo"] = rootRepo
if !fileOnly {
branches, tags, err := getBranchesAndTagsForRepo(ctx.User, rootRepo)
branches, tags, err := getBranchesAndTagsForRepo(rootRepo)
if err != nil {
ctx.ServerError("GetBranchesForRepo", err)
return nil
Expand All @@ -458,7 +458,7 @@ func ParseCompareInfo(ctx *context.Context) *CompareInfo {
if canRead {
ctx.Data["OwnForkRepo"] = ownForkRepo
if !fileOnly {
branches, tags, err := getBranchesAndTagsForRepo(ctx.User, ownForkRepo)
branches, tags, err := getBranchesAndTagsForRepo(ownForkRepo)
if err != nil {
ctx.ServerError("GetBranchesForRepo", err)
return nil
Expand Down Expand Up @@ -630,7 +630,7 @@ func PrepareCompareDiff(
return false
}

func getBranchesAndTagsForRepo(user *models.User, repo *models.Repository) (branches, tags []string, err error) {
func getBranchesAndTagsForRepo(repo *models.Repository) (branches, tags []string, err error) {
gitRepo, err := git.OpenRepository(repo.RepoPath())
if err != nil {
return nil, nil, err
Expand Down